On 2009/04/16 11:22:04, Kasper Lund wrote: > LGTM. > http://codereview.chromium.org/75035/diff/1003/1007 > File src/objects.cc (right):
> http://codereview.chromium.org/75035/diff/1003/1007#newcode5885 > Line 5885: (NumberToUint32(numbers->get(j-1)) > > j-1 -> j - 1 Done for all occurrences. > http://codereview.chromium.org/75035/diff/1003/1008 > File src/objects.h (right): > http://codereview.chromium.org/75035/diff/1003/1008#newcode1589 > Line 1589: // numbers array are equal, the elements are only swapped once. > equal -> identical (or the same object) > http://codereview.chromium.org/75035/diff/1003/1008#newcode1593 > Line 1593: // numbers. If the numbers array and the this array are equal, the > Again. Yes, thanks. I went for 'the same object'. > http://codereview.chromium.org/75035/diff/1003/1005 > File test/mjsunit/enumeration-order.js (right): > http://codereview.chromium.org/75035/diff/1003/1005#newcode57 > Line 57: // Validate the enumeration order for object literals up to 100 named > properties. > Long line. Not your fault. Fixed. http://codereview.chromium.org/75035 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
