Reviewers: Søren Gjesse, Description: - Fix buffer overflow in the pre-allocated memory thread.
Please review this at http://codereview.chromium.org/67248 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/top.cc M test/mjsunit/regexp-multiline-stack-trace.js Index: src/top.cc =================================================================== --- src/top.cc (revision 1730) +++ src/top.cc (working copy) @@ -123,8 +123,8 @@ local_buffer.length()); // Publish the local buffer and signal its availability. - data_ = &local_buffer[0]; - length_ = sizeof(local_buffer); + data_ = local_buffer.start(); + length_ = local_buffer.length(); data_ready_semaphore_->Signal(); while (keep_running_) { Index: test/mjsunit/regexp-multiline-stack-trace.js =================================================================== --- test/mjsunit/regexp-multiline-stack-trace.js (revision 1730) +++ test/mjsunit/regexp-multiline-stack-trace.js (working copy) @@ -25,6 +25,8 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +// The flags below are to test the trace-calls functionality and the +// preallocated meessage memory. // Flags: --trace-calls --preallocate-message-memory /** --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
