Author: [email protected]
Date: Thu Apr 16 17:57:21 2009
New Revision: 1733

Modified:
    branches/bleeding_edge/src/top.cc
    branches/bleeding_edge/test/mjsunit/regexp-multiline-stack-trace.js

Log:
- Fix buffer overflow in the pre-allocated memory thread.

Review URL: http://codereview.chromium.org/67248

Modified: branches/bleeding_edge/src/top.cc
==============================================================================
--- branches/bleeding_edge/src/top.cc   (original)
+++ branches/bleeding_edge/src/top.cc   Thu Apr 16 17:57:21 2009
@@ -123,8 +123,8 @@
                  local_buffer.length());

      // Publish the local buffer and signal its availability.
-    data_ = &local_buffer[0];
-    length_ = sizeof(local_buffer);
+    data_ = local_buffer.start();
+    length_ = local_buffer.length();
      data_ready_semaphore_->Signal();

      while (keep_running_) {

Modified:  
branches/bleeding_edge/test/mjsunit/regexp-multiline-stack-trace.js
==============================================================================
--- branches/bleeding_edge/test/mjsunit/regexp-multiline-stack-trace.js  
(original)
+++ branches/bleeding_edge/test/mjsunit/regexp-multiline-stack-trace.js Thu  
Apr 16 17:57:21 2009
@@ -25,6 +25,8 @@
  // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+// The flags below are to test the trace-calls functionality and the
+// preallocated meessage memory.
  // Flags: --trace-calls --preallocate-message-memory

  /**

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to