LGTM. On Fri, Apr 17, 2009 at 4:07 PM, <[email protected]> wrote:
> Reviewers: Kevin Millikin, > > Description: > Improve coverage of line 619 in stub-cache-arm.cc > > Please review this at http://codereview.chromium.org/77028 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M test/mjsunit/constant-folding.js > > > Index: test/mjsunit/constant-folding.js > =================================================================== > --- test/mjsunit/constant-folding.js (revision 1734) > +++ test/mjsunit/constant-folding.js (working copy) > @@ -168,4 +168,29 @@ > assertEquals(17, j, "switch with constant value"); > } > > + > +function TrueToString() { > + return true.toString(); > +} > + > + > +function FalseToString() { > + return false.toString(); > +} > + > + > +function BoolTest() { > + assertEquals("true", TrueToString()); > + assertEquals("true", TrueToString()); > + assertEquals("true", TrueToString()); > + assertEquals("false", FalseToString()); > + assertEquals("false", FalseToString()); > + assertEquals("false", FalseToString()); > + Boolean.prototype.toString = function() { return "foo"; } > + assertEquals("foo", TrueToString()); > + assertEquals("foo", FalseToString()); > +} > + > + > test(); > +BoolTest(); > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
