LGTM!
http://codereview.chromium.org/77014/diff/1/2 File test/mjsunit/tools/profile.js (right): http://codereview.chromium.org/77014/diff/1/2#newcode87 Line 87: ProfileTestDriver.prototype.enter = function(funcName) { Please add a comment about TOS being in stack_[0] therefore unshith/shits is used instead of push/pop. http://codereview.chromium.org/77014/diff/1/4 File tools/profile.js (right): http://codereview.chromium.org/77014/diff/1/4#newcode79 Line 79: name, startAddr, endAddr) { Why does addStaticCode use startAddr and endAddr and addCode use addr and size for specifying the code range? http://codereview.chromium.org/77014/diff/1/4#newcode149 Line 149: devtools.profiler.Profile.prototype.processStack_ = function(stack) { procesStack seems a bit generic, how about resolveFunctionNames? http://codereview.chromium.org/77014/diff/1/4#newcode250 Line 250: devtools.profiler.Profile.DynamicCodeEntry.prototype.getName = function() { Why is type not added to anonymous functions? http://codereview.chromium.org/77014/diff/1/4#newcode254 Line 254: } else if (name.charAt(0) == ' ') { Please explain this ' ' name check. http://codereview.chromium.org/77014 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
