Thanks for the comments.
http://codereview.chromium.org/88022/diff/1/2 File src/array.js (right): http://codereview.chromium.org/88022/diff/1/2#newcode891 Line 891: find_initial: if (%_ArgumentsLength() < 2) { I use the label to have a location to break to, to avoid executing the throw if we don't find an element. I preferred adding the label to the existing statement instead of creating another block statement inside the if. http://codereview.chromium.org/88022/diff/1/2#newcode891 Line 891: find_initial: if (%_ArgumentsLength() < 2) { On 2009/04/21 09:39:17, Christian Plesner Hansen wrote: > I think the code style is > find_initial: > if (%_...) Done. http://codereview.chromium.org/88022/diff/1/2#newcode892 Line 892: for (;i < length; i++) { On 2009/04/21 09:19:50, Dean McNamee wrote: > space after ; Done. http://codereview.chromium.org/88022/diff/1/2#newcode913 Line 913: throw MakeTypeError('called_non_callable', [ callback ]); On 2009/04/21 09:19:50, Dean McNamee wrote: > no spaces around [ ] (consistency with []) Done. http://codereview.chromium.org/88022 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
