LGTM

http://codereview.chromium.org/88026/diff/1001/1002
File include/v8.h (right):

http://codereview.chromium.org/88026/diff/1001/1002#newcode1049
Line 1049: // Sets a local property on this object, bypassing
interceptors and
For now this only forces the set for string keys, right?  We should
probably document here that the set is not forced if the key can be
converted to an array index.

http://codereview.chromium.org/88026/diff/1001/1006
File src/objects.cc (right):

http://codereview.chromium.org/88026/diff/1001/1006#newcode1823
Line 1823: case CALLBACKS: case INTERCEPTOR:
Two lines?

http://codereview.chromium.org/88026

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to