Author: [email protected]
Date: Tue Apr 21 06:28:34 2009
New Revision: 1753

Modified:
    branches/bleeding_edge/include/v8.h
    branches/bleeding_edge/src/objects.cc

Log:
review


Modified: branches/bleeding_edge/include/v8.h
==============================================================================
--- branches/bleeding_edge/include/v8.h (original)
+++ branches/bleeding_edge/include/v8.h Tue Apr 21 06:28:34 2009
@@ -1052,6 +1052,8 @@
    // Note that if the object has an interceptor the property will be set
    // locally, but since the interceptor takes precedence the local property
    // will only be returned if the interceptor doesn't return a value.
+  //
+  // Note also that this only works for named properties.
    bool ForceSet(Handle<Value> key,
                  Handle<Value> value,
                  PropertyAttribute attribs = None);

Modified: branches/bleeding_edge/src/objects.cc
==============================================================================
--- branches/bleeding_edge/src/objects.cc       (original)
+++ branches/bleeding_edge/src/objects.cc       Tue Apr 21 06:28:34 2009
@@ -1820,7 +1820,8 @@
        if (value == result->GetConstantFunction()) return value;
        // Only replace the function if necessary.
        return ConvertDescriptorToFieldAndMapTransition(name, value,  
attributes);
-    case CALLBACKS: case INTERCEPTOR:
+    case CALLBACKS:
+    case INTERCEPTOR:
        // Override callback in clone
        return ConvertDescriptorToField(name, value, attributes);
      case CONSTANT_TRANSITION:

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to