LGTM

You will need to merge with Yurys last change.




http://codereview.chromium.org/87026/diff/16/1011
File src/debug.cc (right):

http://codereview.chromium.org/87026/diff/16/1011#newcode1807
Line 1807: if (!command_received_->Wait(100) &&
Debugger::host_dispatch_handler_) {
I think we should have an V8::Debug API for setting this, also note that
this timeout is in microseconds, not milliseconds as I told you. I think
the V8::Debug API should take milliseconds though.

http://codereview.chromium.org/87026

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to