Reviewers: Kevin Millikin, Description: Remove if inside contradictory if.
Please review this at http://codereview.chromium.org/93059 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/codegen-ia32.cc Index: src/codegen-ia32.cc =================================================================== --- src/codegen-ia32.cc (revision 1776) +++ src/codegen-ia32.cc (working copy) @@ -1377,9 +1377,7 @@ __ mov(answer.reg(), operand->reg()); ASSERT(kSmiTag == 0); // adjust code if not the case // We do no shifts, only the Smi conversion, if shift_value is 1. - if (shift_value == 0) { - __ sar(answer.reg(), kSmiTagSize); - } else if (shift_value > 1) { + if (shift_value > 1) { __ shl(answer.reg(), shift_value - 1); } // Convert int result to Smi, checking that it is in int range. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
