LGTM

http://codereview.chromium.org/92120/diff/1/5
File tools/profileview.js (right):

http://codereview.chromium.org/92120/diff/1/5#newcode54
Line 54: callTree.traverse(function(node, viewParent) {
I woud prefer to have this function defined as an inner function in
devtools.profiler.ViewBuilder.prototype.buildView instead of being
defined anonomous in the arguments list.

http://codereview.chromium.org/92120

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to