LGTM.
http://codereview.chromium.org/93121/diff/1/5 File src/arm/builtins-arm.cc (right): http://codereview.chromium.org/93121/diff/1/5#newcode434 Line 434: __ mov(ip, Operand(Smi::FromInt(0))); Maybe use r0 instead of ip here? Some of the complex ARM assembler "instructions" (not these though) manipulate ip behind the scenes. http://codereview.chromium.org/93121/diff/1/6 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/93121/diff/1/6#newcode4601 Line 4601: __ mov(ip, Operand(Smi::FromInt(0))); ip -> r0? http://codereview.chromium.org/93121 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
