LGTM I am looking forward to trying this out!
http://codereview.chromium.org/99054/diff/1/7 File tools/consarray.js (right): http://codereview.chromium.org/99054/diff/1/7#newcode74 Line 74: ConsArray.prototype.next = function() { Maybe throw an exception if atEnd. http://codereview.chromium.org/99054/diff/1001/36 File tools/tickprocessor.js (right): http://codereview.chromium.org/99054/diff/1001/36#newcode57 Line 57: this.cppEntriesProvider = cppEntriesProvider; Trailing underscores? http://codereview.chromium.org/99054/diff/1001/36#newcode295 Line 295: function(name) { return self.isSharedLibrary(name); }, Indent two more. http://codereview.chromium.org/99054 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
