I don't know why Rietweld garbeled my nicely formatted description...
Changed the debugger message API to receive an object instead of a
JSON string.
The object delivered to the debug message handler contains additional
information on the current break handling the messages.
Clients which require just JSON message parsing can simply get the JSON
using the GetJSON message on the message object to still have the previous
behaviour.
NewMessageHangler(const v8::Debug::Message& message) {
v8::String::Value val(message.GetJSON());
OldMessageHandler(Vector<uint16_t>(const_cast<uint16_t*>(*val), val.length()));
}
Refactored some of the debugger code to use internal handles instead of API
handles. Also changed Object to JSObject is some places.
The access to the active context when the break occurred is still not
implemented. I will add this in a new CL, as this one is quite big already.
/Søren
On Tue, Apr 28, 2009 at 13:15, <[email protected]> wrote:
> Reviewers: Yury Semikhatsky, Christian Plesner Hansen,
>
> Description:
> Changed the debugger message API to receive an object instead of a JSON
> string.The object delivered to the debug message handler contains
> additional information on the current break handling the
> messages.Clients which require just JSON message parsing can simply get
> the JSON using the GetJSON message on the message object to still have
> the previous behaviour.NewMessageHangler(const v8::Debug::Message&
> message) { v8::String::Value val(message.GetJSON());
> OldMessageHandler( Vector<uint16_t>(const_cast<uint16_t*>(*val),
> val.length()));}Refactored some of the debugger code to use internal
> handles instead of API handles. Also changed Object to JSObject is some
> places.The access to the active context when the break occurred is still
> not implemented. I will add this in a new CL, as this one is quite big
> already.
>
> Please review this at http://codereview.chromium.org/99122
>
> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
>
> Affected files:
> M include/v8-debug.h
> M src/debug-agent.h
> M src/debug-agent.cc
> M src/debug.h
> M src/debug.cc
> M test/cctest/test-debug.cc
>
>
>
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
