Updated again. Code regression fixed.
http://codereview.chromium.org/99052/diff/1004/6 File src/ia32/virtual-frame-ia32.cc (right): http://codereview.chromium.org/99052/diff/1004/6#newcode324 Line 324: // Copy contents of from from from to to to merge to expected. On 2009/04/28 11:39:47, Kevin Millikin wrote: > This comment is cute, but it's probably better to have something that the reader > will understand no matter what's their native language. The other code in this > file uses "source" and "target". Done. http://codereview.chromium.org/99052/diff/1004/6#newcode327 Line 327: elements_[index].set_reg(to); On 2009/04/28 11:39:47, Kevin Millikin wrote: > It doesn't make a huge difference, but the rest of the virtual frame tends to > make state changes first, then emit code to make them true. Done. http://codereview.chromium.org/99052/diff/1004/6#newcode345 Line 345: // final step and is done from the bottom up so that the backing On 2009/04/28 11:39:47, Kevin Millikin wrote: > There is a code quality regression to address: before, we moved memory to > register before moving possible copies to registers (so we could minimize memory > reads). Now we can emit extra memory reads depending on register iteration > order. Done. http://codereview.chromium.org/99052/diff/1004/6#newcode389 Line 389: if (!source.is_register()) { Use(target.reg(), index); } On 2009/04/28 11:39:47, Kevin Millikin wrote: > The style rule for V8 code is if a single line body is on the same line as the > test, no braces. (And if there's braces, then it's not on the same line as the > test. You shouldn't have both.) Done. http://codereview.chromium.org/99052 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
