LGTM for the code part. I don't know enough about the expectations for the soname version to know if this approach will suit our needs.
http://codereview.chromium.org/100104/diff/1013/1025 File SConstruct (right): http://codereview.chromium.org/100104/diff/1013/1025#newcode231 Line 231: }, accidental edit? http://codereview.chromium.org/100104/diff/1013/1025#newcode610 Line 610: Abort("Shared Object soname not applicable for Linux.") Linux -> Windows http://codereview.chromium.org/100104 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
