LGTM
http://codereview.chromium.org/99181/diff/1/4 File tools/profile_view.js (right): http://codereview.chromium.org/99181/diff/1/4#newcode79 Line 79: this.head = head; Trailing underscores? http://codereview.chromium.org/99181/diff/1/4#newcode97 Line 97: destProfile[profileNames[j]] = this[profileNames[j]]; This means that each profile references itself as well as the other two. Is the reference to itself required by WebKit ProfileView? http://codereview.chromium.org/99181/diff/1/4#newcode215 Line 215: this.callIdentifier = 0; Trailing underscores? http://codereview.chromium.org/99181/diff/1/4#newcode231 Line 231: /^(?:LazyCompile|Function): (.*)$/; Maybe we should go and change the logged strings instead of making these part of the function name... http://codereview.chromium.org/99181 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
