LGTM
http://codereview.chromium.org/100249/diff/1/9 File src/objects-inl.h (right): http://codereview.chromium.org/100249/diff/1/9#newcode218 Line 218: } else if ((type & kStringRepresentationMask) == kConsStringTag && You can omit the "else" here, since the former condition always returns. http://codereview.chromium.org/100249/diff/1/2 File test/cctest/test-api.cc (right): http://codereview.chromium.org/100249/diff/1/2#newcode6242 Line 6242: "/[^a-z]/.test(slice_on_cons);"); Perhaps add a comment stating what is being tested here (that flattens works). http://codereview.chromium.org/100249 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
