LGTM.
http://codereview.chromium.org/100330/diff/1/2 File test/mjsunit/array-sort.js (left): http://codereview.chromium.org/100330/diff/1/2#oldcode334 Line 334: assertFalse(x.hasOwnProperty(11), name + "hasundefined11"); Is what this test is meant to test still tested? http://codereview.chromium.org/100330/diff/1/2 File test/mjsunit/array-sort.js (right): http://codereview.chromium.org/100330/diff/1/2#newcode264 Line 264: assertEquals(length, y.length, name +"length"); name + "length" ? Spaces on both sides of operator. http://codereview.chromium.org/100330/diff/1/2#newcode271 Line 271: assertEquals(x.hasOwnProperty(i), y.hasOwnProperty(i), Remove space at end of line. http://codereview.chromium.org/100330 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
