http://codereview.chromium.org/100337/diff/1/4 File src/objects.h (right):
http://codereview.chromium.org/100337/diff/1/4#newcode801 Line 801: static const int kMaxValue = (1 << (kSmiPrecission - (kSmiTagSize))) - 1; I would call this kSmiNumBits, precision (spelling) doesn't really make it clear that it's the number of bits. http://codereview.chromium.org/100337/diff/1/4#newcode2329 Line 2329: reinterpret_cast<uintptr_t>(address()), Do we really need this, both should be returning pointers, instruction_start returns a byte*, and address returns an Address (which is also a byte*). Is there something about subtracting pointers I'm missing? http://codereview.chromium.org/100337 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
