Thanks. I'm looking into it. On Mon, May 4, 2009 at 10:19 PM, Erik Corry <[email protected]> wrote:
> This change triggers an assert in the debug tests. Could well be > harmless. > > 2009/5/4 <[email protected]> > > >> >> http://codereview.chromium.org/100344/diff/1/3 >> File src/mark-compact.cc (right): >> >> http://codereview.chromium.org/100344/diff/1/3#newcode588 >> Line 588: // not receive a weak reference callback. >> I don't think so. The problem was that the weak reference callback was >> getting called for the external string. With no callback, there should >> not be any (err, this) problem. >> >> http://codereview.chromium.org/100344/diff/1/3#newcode601 >> Line 601: SetMark(symbol_table); >> This was just the simplest implementation to get a fix out asap. It >> leverages all the existing infrastructure for recursive marking and >> handling (the admittedly as close to impossible as possible) marking >> stack overflow. I agree that it's dodgy. >> >> http://codereview.chromium.org/100344 >> >> >> > > > -- > Erik Corry, Software Engineer > Google Denmark ApS. CVR nr. 28 86 69 84 > c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen > K, Denmark. > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
