The change itself seems correct, and I think having the code generator compile an inline function for this is a pretty clever idea. We've talked about it a bit in the Aarhus office, and there is really no ideal way to proceed. We want to have the test, in the same configuration as product releases. We don't like having special code in the VM that's only for testing---we used to have some code like that and have taken it out.
I like best your idea of patching the set of inline functions in the test. On Tue, May 5, 2009 at 9:43 AM, <[email protected]> wrote: > > On 2009/04/28 08:06:32, Mikhail Naganov wrote: > > > Kevin, any chances to get this change reviewed? > > If having an inlined function that is only used for testing seems > unacceptable, let's allow InlineRuntimeLUT array patching at runtime. > Then my function will only be installed from tests. > > http://codereview.chromium.org/100100 > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
