LGTM. STV. On Tue, May 5, 2009 at 11:43 AM, <[email protected]> wrote:
> Reviewers: William Hesse, Mads Ager, > > Message: > Quick fix. > > Description: > Changed definition of INT64_C and UINT64_C to use the one in stdint.h. > Since Chromium build system appears to define __STDC_CONSTANT_MACROS, we > might as well use the macro definitions from stdint.h in all cases. > > Please review this at http://codereview.chromium.org/109016 > > Affected files: > M include/v8.h > M src/globals.h > > > Index: include/v8.h > diff --git a/include/v8.h b/include/v8.h > index > 068a1cdef58ee29d7dfdb0b52f1884f9ae6e757b..dde78a1731f818f7e039f994d28887ba9406784a > 100644 > --- a/include/v8.h > +++ b/include/v8.h > @@ -77,7 +77,9 @@ typedef unsigned __int64 uint64_t; > #endif // BUILDING_V8_SHARED > > #else // _WIN32 > - > +#ifndef __STDC_CONSTANT_MACROS > +#define __STDC_CONSTANT_MACROS > +#endif > #include <stdint.h> > > // Setup for Linux shared library export. There is no need to destinguish > Index: src/globals.h > diff --git a/src/globals.h b/src/globals.h > index > 35208c4399d25b9d58bfd0f86b4cdc0c03a0c49b..71bb78e3552a0f4cc871a136f1835956fdb3d20e > 100644 > --- a/src/globals.h > +++ b/src/globals.h > @@ -54,9 +54,6 @@ typedef byte* Address; > #ifdef _MSC_VER > #define UINT64_C(x) (x ## UI64) > #define INT64_C(x) (x ## I64) > -#else > -#define UINT64_C(x) (x ## ULL) > -#define INT64_C(x) (x ## LL) > #endif > > // Code-point values in Unicode 4.0 are 21 bits wide. > > > -- We can IMAGINE what is not --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
