LGTM, with comments.
http://codereview.chromium.org/109017/diff/1/2 File src/globals.h (right): http://codereview.chromium.org/109017/diff/1/2#newcode61 Line 61: #define V8_INT64_C(x) (x ## LL) The definition in stdint.h is: # if __WORDSIZE == 64 # define __INT64_C(c) c ## L # define __UINT64_C(c) c ## UL # else # define __INT64_C(c) c ## LL # define __UINT64_C(c) c ## ULL # endif The macros should work in 32-bit mode as well (or not be defined if they don't), so we should probably do both versions. Possibly two versions for MSVC as well. http://codereview.chromium.org/109017 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
