Reviewers: Dean McNamee,

Message:
QUick review.

Description:
X64 adaption: Changed a constant from kBitsPerPointer to kBitsPerInt.
Still stays within the size of Smi and works with a uint32_t bitfield.
Bitfield might need to be extended to handle a larger base.

Please review this at http://codereview.chromium.org/109020

Affected files:
   M src/code-stubs.h


Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index  
d21b0eed215a40bc1221ce780af8dc79a3279855..434ddec5295d607ad710db30013747ec83a8180f
  
100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -72,7 +72,7 @@ class CodeStub BASE_EMBEDDED {

   protected:
    static const int kMajorBits = 5;
-  static const int kMinorBits = kBitsPerPointer - kMajorBits - kSmiTagSize;
+  static const int kMinorBits = kBitsPerInt - kMajorBits - kSmiTagSize;

   private:
    // Generates the assembler code for the stub.



--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to