On Tue, May 5, 2009 at 4:04 PM, <[email protected]> wrote: > LGTM. Are you sure JSC passes the test cases?
... and of course it only looks good if it actually solves crbug.com/1717 :-) > http://codereview.chromium.org/109004/diff/1002/1009 > File src/bootstrapper.cc (right): > > http://codereview.chromium.org/109004/diff/1002/1009#newcode1478 > Line 1478: // Remember to skip the hidden prototype: > : -> . Rename prototype to hidden_prototype and prototype2 to prototype? > > http://codereview.chromium.org/109004/diff/1002/1004 > File src/runtime.cc (right): > > http://codereview.chromium.org/109004/diff/1002/1004#newcode485 > Line 485: RUNTIME_ASSERT(!jsobject->GetPrototype()->IsHeapObject() || > The first RUNTIME_ASSERT could use an explaining comment. > > http://codereview.chromium.org/109004 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
