LGTM On Tue, May 5, 2009 at 4:31 PM, <[email protected]> wrote:
> Reviewers: William Hesse, > > Description: > Make sure to report out-of-memory situations when the > heap returns RetryAfterGC even when forced to always > allocate. > > Please review this at http://codereview.chromium.org/109023 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/heap-inl.h > > > Index: src/heap-inl.h > =================================================================== > --- src/heap-inl.h (revision 1867) > +++ src/heap-inl.h (working copy) > @@ -251,11 +251,11 @@ > __object__ = FUNCTION_CALL; \ > } \ > if (!__object__->IsFailure()) RETURN_VALUE; \ > - if (__object__->IsOutOfMemoryFailure()) { > \ > + if (__object__->IsOutOfMemoryFailure() || > \ > + __object__->IsRetryAfterGC()) { > \ > /* TODO(1181417): Fix this. */ \ > v8::internal::V8::FatalProcessOutOfMemory("CALL_AND_RETRY_2"); \ > } \ > - ASSERT(!__object__->IsRetryAfterGC()); > \ > RETURN_EMPTY; \ > } while (false) > > > > -- We can IMAGINE what is not --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
