LGTM with a few comments.
http://codereview.chromium.org/109026/diff/1008/1013 File src/mirror-delay.js (right): http://codereview.chromium.org/109026/diff/1008/1013#newcode762 Line 762: FunctionMirror.prototype.inferred_name = function() { inferred_name -> inferredName http://codereview.chromium.org/109026/diff/1008/1013#newcode870 Line 870: return ''; Please return undefined. http://codereview.chromium.org/109026/diff/1008/1013#newcode1852 Line 1852: content.push(MakeJSONPair_('inferredName', Add if (!IS_UNDEFINED(mirror.inferredName()) ... http://codereview.chromium.org/109026/diff/1008/1011 File src/runtime.cc (right): http://codereview.chromium.org/109026/diff/1008/1011#newcode1103 Line 1103: static Object* Runtime_FunctionGetInferredName(Arguments args) { Move to the #ifdef ENABLE_DEBUGGER_SUPPORT section below. http://codereview.chromium.org/109026/diff/1008/1012 File src/runtime.h (right): http://codereview.chromium.org/109026/diff/1008/1012#newcode163 Line 163: F(FunctionGetInferredName, 1) \ Move this to the debugger section below (inside #ifdef ENABLE_DEBUGGER_SUPPORT) http://codereview.chromium.org/109026 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
