http://codereview.chromium.org/109025/diff/1/2
File src/platform-linux.cc (right):

http://codereview.chromium.org/109025/diff/1/2#newcode608
Line 608: sample.pc = mcontext.gregs[REG_RIP];
It does compile, but I'll just do UNIMPLEMENTED :\

On 2009/05/06 11:05:27, Lasse Reichstein wrote:
> Does the assignment compile, and throw away the upper half of the
value
> silently? If so, I'd prefer an UNIMPLEMENTED() in front of it with a
comment
> saying to not remove it unitl sample.pc allows 64 bits.

http://codereview.chromium.org/109025

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to