http://codereview.chromium.org/115021/diff/1011/6 File src/x64/assembler-x64.h (right):
http://codereview.chromium.org/115021/diff/1011/6#newcode35 Line 35: // A light-weight X64 Assembler. "light-weight" => "lightweight" http://codereview.chromium.org/115021/diff/1011/6#newcode64 Line 64: // kNumRegisters == 16 is not declared yet. Why not move its declaration? Or it actually makes sense just to make it a static const in struct Register. http://codereview.chromium.org/115021/diff/1011/6#newcode67 Line 67: // The byte-register distinction of ai32 has dissapeared. ai32? If it's disappeared, why not just get rid of the function? http://codereview.chromium.org/115021/diff/1011/6#newcode78 Line 78: // (unfortunately we can't make this private in a struct) This is my new favorite comment. http://codereview.chromium.org/115021 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
