LGTM when it LGTDean 2009/5/6 <[email protected]>
> > http://codereview.chromium.org/113030/diff/1/2 > File src/v8threads.cc (right): > > http://codereview.chromium.org/113030/diff/1/2#newcode312 > Line 312: void* stored_thread_id = > Thread::GetThreadLocal(thread_id_key); > I would add to platform.h a GetThreadLocalInt, and do the cast there. > > http://codereview.chromium.org/113030/diff/1/2#newcode313 > Line 313: intptr_t thread_id_number = bit_cast<intptr_t, > void*>(stored_thread_id); > this is actually an incorrect use of bit_cast. > > http://codereview.chromium.org/113030/diff/1/2#newcode322 > Line 322: Thread::SetThreadLocal(thread_id_key, bit_cast<void*, > intptr_t>(new_id)); > SetThreadLocalInt > > > http://codereview.chromium.org/113030 > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
