LGTM.

http://codereview.chromium.org/115074/diff/1/3
File src/spaces.h (right):

http://codereview.chromium.org/115074/diff/1/3#newcode601
Line 601: };
I liked the old version better.  Does the style guide mandate this?

http://codereview.chromium.org/115074/diff/1/3#newcode843
Line 843: Page* last_page_;
The way this is updated is subtle.  It at least deserves a comment here.

http://codereview.chromium.org/115074

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to