http://codereview.chromium.org/115076/diff/1/3 File src/globals.h (right):
http://codereview.chromium.org/115076/diff/1/3#newcode85 Line 85: #else // V8_HOST_ARCH_64_BIT Shouldn't this comment say !V8_HOST_ARCH_64_BIT? This nested #if stuff is complicated. How about giving us some whitespace before the inner #ifdef and after the inner #endif? I actually like flattening the whole thing at this site (because there is nothing shared between the the defined(_MSC_VER) and !defined(_MSC_VER) versions) better: #if V8_HOST_ARCH_64_BIT && defined(_MSC_VER) ... #elif V8_HOST_ARCH_64_BIT ... #else ... #endif http://codereview.chromium.org/115076 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
