Reviewers: Kevin Millikin, Description: Allocate proxy before the script to allow heap verification to check that all scripts have a proxy in the wrapper field.
Please review this at http://codereview.chromium.org/115081 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/factory.cc Index: src/factory.cc =================================================================== --- src/factory.cc (revision 1898) +++ src/factory.cc (working copy) @@ -167,6 +167,7 @@ Heap::SetLastScriptId(Smi::FromInt(id)); // Create and initialize script object. + Handle<Proxy> wrapper = Factory::NewProxy(0, TENURED); Handle<Script> script = Handle<Script>::cast(NewStruct(SCRIPT_TYPE)); script->set_source(*source); script->set_name(Heap::undefined_value()); @@ -176,7 +177,7 @@ script->set_data(Heap::undefined_value()); script->set_context_data(Heap::undefined_value()); script->set_type(Smi::FromInt(SCRIPT_TYPE_NORMAL)); - script->set_wrapper(*Factory::NewProxy(0, TENURED)); + script->set_wrapper(*wrapper); script->set_line_ends(Heap::undefined_value()); return script; --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
