LGTM Does it process Bill's 200Mb log-file now? Maybe we still need Java -Xmx like options to the D8 shell for large log files.
http://codereview.chromium.org/113101/diff/1004/8 File tools/codemap.js (right): http://codereview.chromium.org/113101/diff/1004/8#newcode168 Line 168: if (!dynaEntry.nameUpdated_) { Is it alright to access 'private' members using other than this? As CodeEntry in inside CodeMap it is probably fine. http://codereview.chromium.org/113101 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
