2009/5/11 <[email protected]>: > > > Comment #4 on issue 266 by craig.schlenter: Fix strict aliasing problems in > v8/src/third_party/dtoa/dtoa.c > http://code.google.com/p/v8/issues/detail?id=266 > > I've put the changes here: > http://codereview.chromium.org/115176 > after manually merging the v8 local changes into the latest dtoa.c but I > get failures > running the test suite: > > === debug parse-int-float === > Path: mjsunit/parse-int-float > /home/craig/chromium.git/src/v8/test/mjsunit/mjsunit.js:50: Failure: > expected <0> > found <18> > throw new MjsUnitAssertionError(start + " expected <" + expected + "> > found > ^ > Command: /home/craig/chromium.git/src/v8/shell_g > /home/craig/chromium.git/src/v8/test/mjsunit/mjsunit.js > /home/craig/chromium.git/src/v8/test/mjsunit/parse-int-float.js > [08:38|% 100|+ 743|- 1]: Done > > Will have to poke at this in more detail to figure it out :(
Thanks for this work. In order to narrow down the test failure it would be a good idea to give each assertxxx call in parse-int-float.js an extra parameter which is the name of the test. Then, when the test fails it will tell you which test it was that failed. > > > -- > You received this message because you are listed in the owner > or CC fields of this issue, or because you starred this issue. > You may adjust your issue notification preferences at: > http://code.google.com/hosting/settings > > > > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
