LGTM

http://codereview.chromium.org/115227/diff/1/5
File benchmarks/base.js (right):

http://codereview.chromium.org/115227/diff/1/5#newcode37
Line 37: // not accounted for in the benchmark score.
not be

or

are not?

http://codereview.chromium.org/115227/diff/1/3
File benchmarks/splay.js (right):

http://codereview.chromium.org/115227/diff/1/3#newcode65
Line 65: return Math.random();
Maybe we should add a comment here stating that Math.random is
deterministic in the benchmark framework to avoid confusion?

http://codereview.chromium.org/115227/diff/1/3#newcode130
Line 130:
Remove one space?

http://codereview.chromium.org/115227/diff/1/3#newcode164
Line 164:
Remove one space?

http://codereview.chromium.org/115227

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to