http://codereview.chromium.org/113199/diff/1/2 File src/disassembler.cc (right):
http://codereview.chromium.org/113199/diff/1/2#newcode46 Line 46: PrintF("%"V8PRIp" %4"V8PRId" %02x\n", pc, pc - begin, *pc); A quick look at what people do with PRId64 and likes from inttypes.h suggests spaces around. I have added them where we have used the macro. http://codereview.chromium.org/113199/diff/1/2#newcode46 Line 46: PrintF("%"V8PRIp" %4"V8PRId" %02x\n", pc, pc - begin, *pc); It shouldn't say "print a pointer difference". It should say "print a pointer-size value as decimal". I admit that it doesn't say that either. The corresponding standard macros are called, e.g., PRIdPTR, so we should call it something like V8PRIdPTR for consistency. http://codereview.chromium.org/113199/diff/1/4 File src/objects.cc (right): http://codereview.chromium.org/113199/diff/1/4#newcode6729 Line 6729: static_cast<uint32_t>(reinterpret_cast<uintptr_t>(map)); Added http://codereview.chromium.org/113199/diff/1/5 File src/runtime.cc (right): http://codereview.chromium.org/113199/diff/1/5#newcode4448 Line 4448: #ifdef V8_HOST_ARCH_64_BIT Done http://codereview.chromium.org/113199 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
