That is an additional fix. This one applies to both SetProperty and IgnoreAttributesAndSetProperty, and makes property attributes stickwhen replacing a constant function property. Yes, we will probably reverse the effect of this on IgnoreAttributesAndSetProperty, together with changing the other code paths through IgnoreAttributesAndSetProperty. But this makes the same change in both places, to separate one change from the other. I guess it wouldn't hurt anything to drop it from Ignore....
On Tue, May 12, 2009 at 9:48 AM, <[email protected]> wrote: > Isn't this the exact opposite of what we talked about? That property > attributes should be consistently overridden? > > > http://codereview.chromium.org/113197 > -- William Hesse Software Engineer [email protected] Google Denmark ApS Frederiksborggade 20B, 1 sal 1360 København K Denmark CVR nr. 28 86 69 84 If you received this communication by mistake, please don't forward it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
