Reviewers: Dean McNamee,

Message:
Single file review.

Description:
X64: Added stubs for unimplemented disassembler functions.

Please review this at http://codereview.chromium.org/113261

Affected files:
   M src/x64/disasm-x64.cc


Index: src/x64/disasm-x64.cc
diff --git a/src/x64/disasm-x64.cc b/src/x64/disasm-x64.cc
index  
209aa2d3070e48da7890e9457e64fe4718cfd782..89d1d861ec545f3c70c837906e7493d70c72f2f5
  
100644
--- a/src/x64/disasm-x64.cc
+++ b/src/x64/disasm-x64.cc
@@ -25,3 +25,38 @@
  // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+#include "v8.h"
+#include "disasm.h"
+
+namespace disasm {
+
+  Disassembler::Disassembler(NameConverter const& converter)
+      : converter_(converter) {
+    UNIMPLEMENTED();
+  }
+
+  const char* NameConverter::NameOfAddress(unsigned char* addr) const {
+    UNIMPLEMENTED();
+    return NULL;
+  }
+
+  const char* NameConverter::NameOfCPURegister(int reg) const {
+    UNIMPLEMENTED();
+    return NULL;
+  }
+
+  int Disassembler::ConstantPoolSizeAt(unsigned char* addr) {
+    UNIMPLEMENTED();
+    return 0;
+  }
+
+  int Disassembler::InstructionDecode(v8::internal::Vector<char> buffer,
+                                      unsigned char* instruction) {
+    UNIMPLEMENTED();
+    return 0;
+  }
+
+  Disassembler::~Disassembler() {}
+
+
+}  // end namespace disasm



--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to