LGTM On Tue, May 12, 2009 at 3:59 PM, <[email protected]> wrote: > > Reviewers: Christian Plesner Hansen, > > Description: > Valgrind outputs large numbers like 4,096 (with the commas) and > that isn't matched by \d+. Ug. > > Please review this at http://codereview.chromium.org/115238 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M tools/run-valgrind.py > > > Index: tools/run-valgrind.py > =================================================================== > --- tools/run-valgrind.py (revision 1910) > +++ tools/run-valgrind.py (working copy) > @@ -56,7 +56,7 @@ > > # Look through the leak details and make sure that we don't > # have any definitely, indirectly, and possibly lost bytes. > -LEAK_RE = r"(?:definitely|indirectly|possibly) lost: \d+ bytes in \d+ > blocks." > +LEAK_RE = r"(?:definitely|indirectly|possibly) lost: " > LEAK_LINE_MATCHER = re.compile(LEAK_RE) > LEAK_OKAY_MATCHER = re.compile(r"lost: 0 bytes in 0 blocks.") > leaks = [] > > > > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
