LGTM

http://codereview.chromium.org/113329/diff/16/17
File src/ia32/virtual-frame-ia32.h (right):

http://codereview.chromium.org/113329/diff/16/17#newcode497
Line 497: }
This function is identical to the one in virtual-frame-arm.h.
Perhaps it can be moved to a shared file?

http://codereview.chromium.org/113329/diff/16/19
File src/virtual-frame.h (right):

http://codereview.chromium.org/113329/diff/16/19#newcode157
Line 157: return result;
Much more readable.

http://codereview.chromium.org/113329

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to