On 2009/05/13 08:23:07, Mads Ager wrote:
> This looks a lot like what I did when I tried to update the dtoa
version used in
> V8.

> Unfortunately, gcc 4.2.4 has a problem with this version of dtoa when
using -O2
> or above.  I get the following failure only in release mode when using
-O2 or
> above:

> === release number-tostring ===
> Path: mjsunit/number-tostring
> /home/ager/v8/v8/test/mjsunit/mjsunit.js:50: Failure: expected
> <0.00000000000000000010> found <0.0000000000000000000:>

Wow. That's ending in ':' which is one ascii character past 9 so it
looks like it almost got it right and perhaps just forgot to 'carry'
that digit over properly.

> Therefore, I cannot put this patch in as is and we will have to
compile with
> -fno-strict-aliasing on gcc 4.4 for now.

OK. Unfortunately -fno-strict-aliasing doesn't help for the other
crashes I see:

=== release debug-evaluate ===
Path: mjsunit/debug-evaluate
Command: /home/craig/v8/shell --expose-debug-as debug
/home/craig/v8/test/mjsunit/mjsunit.js
/home/craig/v8/test/mjsunit/debug-evaluate.js
--- CRASHED ---
=== release debug-evaluate-locals ===
Path: mjsunit/debug-evaluate-locals
Command: /home/craig/v8/shell --expose-debug-as debug
/home/craig/v8/test/mjsunit/mjsunit.js
/home/craig/v8/test/mjsunit/debug-evaluate-locals.js
--- CRASHED ---
=== release debug-evaluate-with ===
Path: mjsunit/debug-evaluate-with
Command: /home/craig/v8/shell --expose-debug-as debug
/home/craig/v8/test/mjsunit/mjsunit.js
/home/craig/v8/test/mjsunit/debug-evaluate-with.js
--- CRASHED ---

etc.

:(

I'll close this for now and perhaps poke at the other crashes sometime
to see if I can figure anything out.

Thank you.

http://codereview.chromium.org/115176

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to