A lot of ifdefs and a lot of duplicated code for the different platforms :-(.
In src/codegen-inl.h can we have an object that takes care of set_in_spilled_state with its constructor/destructor? Then you can have an empty implementation in debug mode. LGTM I guess. http://codereview.chromium.org/113259/diff/1/4 File src/ia32/codegen-ia32.h (right): http://codereview.chromium.org/113259/diff/1/4#newcode619 Line 619: bool in_spilled_code_; Is it really worth having this only in debug builds? It adds a lot of ifdefs to not always have this. http://codereview.chromium.org/113259 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
