http://codereview.chromium.org/115347/diff/1/8 File src/compiler.cc (right):
http://codereview.chromium.org/115347/diff/1/8#newcode104 Line 104: CompilationZoneScope zone_scope(DELETE_ON_EXIT); On 2009/05/14 11:26:16, Kasper Lund wrote: > Do you ever have CompilationZoneScope that aren't DELETE_ON_EXIT? You could > remove the constructor parameter... Done. http://codereview.chromium.org/115347/diff/1/11 File src/compiler.h (right): http://codereview.chromium.org/115347/diff/1/11#newcode33 Line 33: #include "frame-element.h" On 2009/05/14 11:29:02, Kevin Millikin wrote: > Is it OK to alphabetize these? It is. Done. http://codereview.chromium.org/115347/diff/1/12 File src/frame-element.h (right): http://codereview.chromium.org/115347/diff/1/12#newcode145 Line 145: StaticType static_type() { return StaticType(StaticTypeField::decode(value_)); } On 2009/05/14 11:26:16, Kasper Lund wrote: > Line too long? Done. http://codereview.chromium.org/115347/diff/1/7 File src/jump-target.cc (right): http://codereview.chromium.org/115347/diff/1/7#newcode32 Line 32: #include "jump-target-inl.h" On 2009/05/14 11:29:02, Kevin Millikin wrote: > Same question. Done. http://codereview.chromium.org/115347/diff/1/10 File src/virtual-frame.h (right): http://codereview.chromium.org/115347/diff/1/10#newcode32 Line 32: #include "frame-element.h" On 2009/05/14 11:29:02, Kevin Millikin wrote: > Again. Done. http://codereview.chromium.org/115347 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
