Reviewers: Mads Ager, Message: Hej Mads,
Got the first assert and when I continued the browser crashed since its deref-ing a NULL pointer. Description: Modify assert so it doesn't crash when 'location' is NULL. Saw this when testing the new printing code (not checked in yet). Please review this at http://codereview.chromium.org/113409 SVN Base: http://v8.googlecode.com/svn/trunk/ Affected files: M src/handles-inl.h Index: src/handles-inl.h =================================================================== --- src/handles-inl.h (revision 1927) +++ src/handles-inl.h (working copy) @@ -44,8 +44,8 @@ template <class T> inline T* Handle<T>::operator*() const { - ASSERT(location_ != NULL); - ASSERT(reinterpret_cast<Address>(*location_) != kHandleZapValue); + ASSERT(location_ != NULL && + reinterpret_cast<Address>(*location_) != kHandleZapValue); return *location_; } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
