If you fix this, it LGTM... On Fri, May 15, 2009 at 11:20 AM, <[email protected]> wrote: > > http://codereview.chromium.org/113451/diff/1/2 > File src/ia32/virtual-frame-ia32.cc (right): > > http://codereview.chromium.org/113451/diff/1/2#newcode426 > Line 426: Register target_reg = { i }; > This strikes me as weird. It seems like there are two uses of > expected->elements_[index] left (three if you count the assert). Why not > keep target as it is and introduce target_reg in addition to that? > > http://codereview.chromium.org/113451 >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
