Reviewers: Lasse Reichstein, Description: Fix accidental %% in log format strings that caused "%x" to appear in log file.
Please review this at http://codereview.chromium.org/113454 Affected files: M src/log.cc Index: src/log.cc diff --git a/src/log.cc b/src/log.cc index 1983bdfd6e68b00184217edf7991609f69952c65..08f68fd698979aad8d191585ea60d683c0f21995 100644 --- a/src/log.cc +++ b/src/log.cc @@ -631,7 +631,7 @@ void Logger::HandleEvent(const char* name, Object** location) { #ifdef ENABLE_LOGGING_AND_PROFILING if (!Log::is_enabled() || !FLAG_log_handles) return; LogMessageBuilder msg; - msg.Append("%s,0x%%" V8PRIxPTR "\n", name, location); + msg.Append("%s,0x%" V8PRIxPTR "\n", name, location); msg.WriteToLogFile(); #endif } @@ -850,7 +850,7 @@ void Logger::NewEvent(const char* name, void* object, size_t size) { #ifdef ENABLE_LOGGING_AND_PROFILING if (!Log::is_enabled() || !FLAG_log) return; LogMessageBuilder msg; - msg.Append("new,%s,0x%%" V8PRIxPTR ",%u\n", name, object, + msg.Append("new,%s,0x%" V8PRIxPTR ",%u\n", name, object, static_cast<unsigned int>(size)); msg.WriteToLogFile(); #endif @@ -861,7 +861,7 @@ void Logger::DeleteEvent(const char* name, void* object) { #ifdef ENABLE_LOGGING_AND_PROFILING if (!Log::is_enabled() || !FLAG_log) return; LogMessageBuilder msg; - msg.Append("delete,%s,0x%%" V8PRIxPTR "\n", name, object); + msg.Append("delete,%s,0x%" V8PRIxPTR "\n", name, object); msg.WriteToLogFile(); #endif } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
