LGTM. On Fri, May 15, 2009 at 1:30 PM, <[email protected]> wrote: > > Reviewers: Kevin Millikin, > > Description: > Fix build on arm and x64. > > Note to self: remember all platforms. > > Please review this at http://codereview.chromium.org/115399 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/arm/register-allocator-arm.cc > M src/arm/virtual-frame-arm.h > M src/arm/virtual-frame-arm.cc > M src/x64/virtual-frame-x64.h > > > Index: src/x64/virtual-frame-x64.h > =================================================================== > --- src/x64/virtual-frame-x64.h (revision 1964) > +++ src/x64/virtual-frame-x64.h (working copy) > @@ -179,7 +179,7 @@ > > // Set a frame element to a constant. The index is frame-top relative. > void SetElementAt(int index, Handle<Object> value) { > - Result temp(value, cgen_); > + Result temp(value); > SetElementAt(index, &temp); > } > > Index: src/arm/virtual-frame-arm.cc > =================================================================== > --- src/arm/virtual-frame-arm.cc (revision 1964) > +++ src/arm/virtual-frame-arm.cc (working copy) > @@ -422,8 +422,7 @@ > > Result VirtualFrame::Pop() { > UNIMPLEMENTED(); > - Result invalid(cgen_); > - return invalid; > + return Result(); > } > > > Index: src/arm/virtual-frame-arm.h > =================================================================== > --- src/arm/virtual-frame-arm.h (revision 1964) > +++ src/arm/virtual-frame-arm.h (working copy) > @@ -181,7 +181,7 @@ > > // Set a frame element to a constant. The index is frame-top relative. > void SetElementAt(int index, Handle<Object> value) { > - Result temp(value, cgen_); > + Result temp(value); > SetElementAt(index, &temp); > } > > Index: src/arm/register-allocator-arm.cc > =================================================================== > --- src/arm/register-allocator-arm.cc (revision 1964) > +++ src/arm/register-allocator-arm.cc (working copy) > @@ -96,8 +96,7 @@ > > Result RegisterAllocator::AllocateByteRegisterWithoutSpilling() { > UNIMPLEMENTED(); > - Result invalid(cgen_); > - return invalid; > + return Result(); > } > > > > > > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
