LGTM!
http://codereview.chromium.org/115402/diff/1/3 File src/parser.cc (right): http://codereview.chromium.org/115402/diff/1/3#newcode58 Line 58: class Element { Couldn't the entire Element class be private? http://codereview.chromium.org/115402/diff/1/3#newcode65 Line 65: protected: How about a newline before protected: and private: (repeated)? http://codereview.chromium.org/115402/diff/1/3#newcode65 Line 65: protected: Why do you have both private and protected? Do you ever inherit from PositionStack? http://codereview.chromium.org/115402 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
